FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
142 31 0 0

Files

Class Bugs
com.bitctrl.ReleaseInfo 1
com.bitctrl.beans.AbstractBeanInfo 1
com.bitctrl.beans.BeanUtils 1
com.bitctrl.geo.graph.BaseEdge 1
com.bitctrl.geo.graph.BaseGraph 2
com.bitctrl.geo.graph.tree.TreeUtil 1
com.bitctrl.modell.criteria.ComparisonDAOCriterion 1
com.bitctrl.net.MAC 4
com.bitctrl.resource.Classpath 1
com.bitctrl.resource.Configuration 1
com.bitctrl.swing.UiUtilities 1
com.bitctrl.util.ArrayMemberCombinator 1
com.bitctrl.util.ComparableTupel$ComparableComparator 3
com.bitctrl.util.ComparatorTupel 1
com.bitctrl.util.DefaultComparator 1
com.bitctrl.util.ListIndexComparator 1
com.bitctrl.util.ObservableList 1
com.bitctrl.util.TreeProperties 2
com.bitctrl.util.TreeProperties$Group 1
com.bitctrl.util.jar.JarTools$JarAnalyzer 1
com.bitctrl.util.jar.JarVersionInfo 1
com.bitctrl.util.logging.LoggerTools 1
com.bitctrl.util.resultset.LinearBuffer 1
com.bitctrl.util.resultset.LinearBuffer$1 1

com.bitctrl.ReleaseInfo

Bug Category Details Line Priority
new com.bitctrl.ReleaseInfo(String) invokes substring(0), which returns the original value STYLE DMI_USELESS_SUBSTRING 125 Medium

com.bitctrl.beans.AbstractBeanInfo

Bug Category Details Line Priority
com.bitctrl.beans.AbstractBeanInfo.getPropertyDescriptors() may expose internal representation by returning AbstractBeanInfo.propertyDescriptorCache MALICIOUS_CODE EI_EXPOSE_REP 132 Medium

com.bitctrl.beans.BeanUtils

Bug Category Details Line Priority
com.bitctrl.beans.BeanUtils.toString(Object) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 368 Medium

com.bitctrl.geo.graph.BaseEdge

Bug Category Details Line Priority
com.bitctrl.geo.graph.BaseEdge.equals(Object) checks for operand being a Node BAD_PRACTICE EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS 94 Medium
Unwritten public or protected field: com.bitctrl.geo.graph.BaseEdge.nextIn STYLE UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 102 Medium
Unwritten public or protected field: com.bitctrl.geo.graph.BaseEdge.nextOut STYLE UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 117 Medium

com.bitctrl.geo.graph.BaseGraph

Bug Category Details Line Priority

com.bitctrl.geo.graph.tree.TreeUtil

Bug Category Details Line Priority
Integral division result cast to double or float in com.bitctrl.geo.graph.tree.TreeUtil.necessaryHighOfBPlusTree(int, long) STYLE ICAST_IDIV_CAST_TO_DOUBLE 59 Medium

com.bitctrl.modell.criteria.ComparisonDAOCriterion

Bug Category Details Line Priority
com.bitctrl.modell.criteria.ComparisonDAOCriterion.getValues() may expose internal representation by returning ComparisonDAOCriterion.values MALICIOUS_CODE EI_EXPOSE_REP 163 Medium

com.bitctrl.net.MAC

Bug Category Details Line Priority
com.bitctrl.net.MAC.getAddress() may expose internal representation by returning MAC.address MALICIOUS_CODE EI_EXPOSE_REP 104 Medium
new com.bitctrl.net.MAC(byte[]) may expose internal representation by storing an externally mutable object into MAC.address MALICIOUS_CODE EI_EXPOSE_REP2 83 Medium
Check for oddness that won't work for negative numbers in com.bitctrl.net.MAC.toString() STYLE IM_BAD_CHECK_FOR_ODD 130 Medium
com.bitctrl.net.MAC.toString() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 132 Medium

com.bitctrl.resource.Classpath

Bug Category Details Line Priority
com.bitctrl.resource.Classpath.findClasses(JarFile, String) uses the same code for two branches STYLE DB_DUPLICATE_BRANCHES 80 Medium

com.bitctrl.resource.Configuration

Bug Category Details Line Priority
com.bitctrl.resource.Configuration.getConfiguration() may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 108 Medium

com.bitctrl.swing.UiUtilities

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in com.bitctrl.swing.UiUtilities.setSystemLookAndFeel() STYLE REC_CATCH_EXCEPTION 126 Medium

com.bitctrl.util.ArrayMemberCombinator

Bug Category Details Line Priority
new com.bitctrl.util.ArrayMemberCombinator(Object[], boolean) may expose internal representation by storing an externally mutable object into ArrayMemberCombinator.inputs MALICIOUS_CODE EI_EXPOSE_REP2 49 Medium

com.bitctrl.util.ComparableTupel$ComparableComparator

Bug Category Details Line Priority
Load of known null value in com.bitctrl.util.ComparableTupel$ComparableComparator.compare(Comparable, Comparable) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 36 Medium
com.bitctrl.util.ComparableTupel$ComparableComparator.compare(Comparable, Comparable) negates the return value of Comparable.compareTo(Object) BAD_PRACTICE RV_NEGATING_RESULT_OF_COMPARETO 36 Medium
com.bitctrl.util.ComparableTupel$ComparableComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 26 Medium

com.bitctrl.util.ComparatorTupel

Bug Category Details Line Priority
com.bitctrl.util.ComparatorTupel doesn't override Tupel.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

com.bitctrl.util.DefaultComparator

Bug Category Details Line Priority
com.bitctrl.util.DefaultComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 38 Medium

com.bitctrl.util.ListIndexComparator

Bug Category Details Line Priority
com.bitctrl.util.ListIndexComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 25 Medium

com.bitctrl.util.ObservableList

Bug Category Details Line Priority
Unwritten field: com.bitctrl.util.ObservableList.input CORRECTNESS UWF_UNWRITTEN_FIELD 76 Medium

com.bitctrl.util.TreeProperties

Bug Category Details Line Priority
com.bitctrl.util.TreeProperties doesn't override java.util.Hashtable.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
Class com.bitctrl.util.TreeProperties defines non-transient non-serializable instance field stack BAD_PRACTICE SE_BAD_FIELD Medium

com.bitctrl.util.TreeProperties$Group

Bug Category Details Line Priority
Should com.bitctrl.util.TreeProperties$Group be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 63 Medium

com.bitctrl.util.jar.JarTools$JarAnalyzer

Bug Category Details Line Priority
new com.bitctrl.util.jar.JarTools$JarAnalyzer(String) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 84 Medium

com.bitctrl.util.jar.JarVersionInfo

Bug Category Details Line Priority
com.bitctrl.util.jar.JarVersionInfo.main(String[]) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 88 Medium

com.bitctrl.util.logging.LoggerTools

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in com.bitctrl.util.logging.LoggerTools.setLogDirectory(String, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 143 Medium

com.bitctrl.util.resultset.LinearBuffer

Bug Category Details Line Priority
com.bitctrl.util.resultset.LinearBuffer.toArray() may expose internal representation by returning LinearBuffer.buffer MALICIOUS_CODE EI_EXPOSE_REP 212 Medium

com.bitctrl.util.resultset.LinearBuffer$1

Bug Category Details Line Priority
com.bitctrl.util.resultset.LinearBuffer$1.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 172 Medium